After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700520 - The songs view is not according to the design.
The songs view is not according to the design.
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-17 12:20 UTC by Sai Suman Prayaga
Modified: 2013-05-20 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mockup. (104.83 KB, image/png)
2013-05-17 12:20 UTC, Sai Suman Prayaga 		  Details
patch for the songs view. (3.99 KB, patch)
2013-05-17 12:24 UTC, Sai Suman Prayaga 		needs-work Details | Review
Updated patch. (3.72 KB, patch)
2013-05-17 13:46 UTC, Sai Suman Prayaga 		none Details | Review
Updated patch. (6.07 KB, patch)
2013-05-19 15:37 UTC, Sai Suman Prayaga 		committed Details | Review
Songs view fix (6.11 KB, patch)
2013-05-19 16:46 UTC, Vadim Rutkovsky 		committed Details | Review

Description Sai Suman Prayaga 2013-05-17 12:20:42 UTC 
Created attachment 244513 [details]
mockup.

The songs view in the mockup has no albumart to its left and list of artists changed according to the design.
Comment 1 Sai Suman Prayaga 2013-05-17 12:24:24 UTC 
Created attachment 244515 [details] [review]
patch for the songs view.

Changed the songs view according to the design and removed the album-art to the left.
Comment 2 Seif Lotfy 2013-05-17 13:36:01 UTC 
Review of attachment 244515 [details] [review]:

::: src/view.js
@@ +379,3 @@
+                );
+            GLib.idle_add(300, Lang.bind(this, this._updateAlbumArt, item, iter));
+

We dont need album art in this view AFAICT. So why the _updateAlbumArt call
Comment 3 Sai Suman Prayaga 2013-05-17 13:46:56 UTC 
Created attachment 244535 [details] [review]
Updated patch.

Thanks for the review :-)
Comment 4 Sai Suman Prayaga 2013-05-19 15:37:07 UTC 
Created attachment 244715 [details] [review]
Updated patch.

Added starred/favorite songs icon and changed the model.
Comment 5 Vadim Rutkovsky 2013-05-19 16:46:15 UTC 
The following fix has been pushed:
56f2866 Songs view fix
Comment 6 Vadim Rutkovsky 2013-05-19 16:46:23 UTC 
Created attachment 244721 [details] [review]
Songs view fix
Comment 7 Vadim Rutkovsky 2013-05-19 16:53:20 UTC 
I pushed the fx, but it still needs some polishing:

+ const starIconName = GdkPixbuf.Pixbuf.new_from_file('/usr/share/icons/gnome/scalable/status/starred-symbolic.svg');

Don't use hardcode paths here, please use iconName same as errorIconName or nowPlayingIconName
Comment 8 Seif Lotfy 2013-05-19 18:16:43 UTC 
Yeah, I would rather have it polished then pushed honestly. There is also unused variables in the patch, and the styling is all wrong although i pointed that out before. Also the stuff the Vadim pointed out needs to be fixed too
Comment 9 Seif Lotfy 2013-05-19 18:18:19 UTC 
Ok I am giving Sai a couple of minutes to come up with some of the small fixes.
Comment 10 Seif Lotfy 2013-05-20 19:15:23 UTC 
All changes pushed to master :D