After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699975 - Remove all simple uses of ClutterRectangle
Remove all simple uses of ClutterRectangle
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-09 01:55 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-05-09 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lookingGlass: Remove an unused separator between results (1020 bytes, patch)
2013-05-09 01:56 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
lookingGlass: Remove a useless container (2.30 KB, patch)
2013-05-09 01:56 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dnd: Clean up construction (971 bytes, patch)
2013-05-09 01:56 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Remove simple uses of ClutterRectangle (3.97 KB, patch)
2013-05-09 01:56 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-05-09 01:55:58 UTC 
This leaves one use left -- the rubberband selection rectangle
in screenshot.js. This is using border colors dynamically from
the GTK+ theme, so I believe it makes sense to just wait until
we have more information on Clutter.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-05-09 01:56:01 UTC 
Created attachment 243660 [details] [review]
lookingGlass: Remove an unused separator between results

At one time, this may have had styling, but it's not there now,
and I don't see a reason to add it back.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-09 01:56:08 UTC 
Created attachment 243662 [details] [review]
lookingGlass: Remove a useless container
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-05-09 01:56:13 UTC 
Created attachment 243663 [details] [review]
dnd: Clean up construction
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-09 01:56:31 UTC 
Created attachment 243664 [details] [review]
Remove simple uses of ClutterRectangle
Comment 5 drago01 2013-05-09 13:19:45 UTC 
Review of attachment 243660 [details] [review]:

OK.
Comment 6 drago01 2013-05-09 13:20:24 UTC 
Review of attachment 243662 [details] [review]:

OK.
Comment 7 drago01 2013-05-09 13:20:50 UTC 
Review of attachment 243663 [details] [review]:

OK.
Comment 8 drago01 2013-05-09 13:21:41 UTC 
Review of attachment 243664 [details] [review]:

LG.
Comment 9 drago01 2013-05-09 13:23:04 UTC 
(In reply to comment #0)
> This leaves one use left -- the rubberband selection rectangle
> in screenshot.js. This is using border colors dynamically from
> the GTK+ theme, so I believe it makes sense to just wait until
> we have more information on Clutter.

Which kind of information?
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-05-09 13:39:09 UTC 
(In reply to comment #9)
> Which kind of information?

What's Clutter 2.0 up to, where is it going, should we care about deprecations yet? Those sort of questions.
Comment 11 drago01 2013-05-09 13:44:27 UTC 
(In reply to comment #10)
> (In reply to comment #9)
> > Which kind of information?
> 
> What's Clutter 2.0 up to, where is it going, should we care about deprecations
> yet? Those sort of questions.

We will get a 1.16 for 3.10
Comment 12 Jasper St. Pierre (not reading bugmail) 2013-05-09 13:49:33 UTC 
Attachment 243660 [details] pushed as ecd838b - lookingGlass: Remove an unused separator between results
Attachment 243662 [details] pushed as 938b1ff - lookingGlass: Remove a useless container
Attachment 243663 [details] pushed as 9c839cd - dnd: Clean up construction
Attachment 243664 [details] pushed as db89648 - Remove simple uses of ClutterRectangle