After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699961 - 'Recently Played' only plays 2 tracks when ordered by Last Played
'Recently Played' only plays 2 tracks when ordered by Last Played
Status: RESOLVED DUPLICATE of bug 670833
Product: banshee
Classification: Other
Component: Smart Playlists
git master
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-08 22:03 UTC by Brian Brooks
Modified: 2013-05-11 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Brian Brooks 2013-05-08 22:03:43 UTC
To reproduce: Sort 'Recently Played' ascending by Last Played.  Play the 2nd track.

Before the next song is picked, the track is moved to the top.  This behavior causes a loop where only two songs are played!

Here is another thread on the issue: http://askubuntu.com/questions/99354/how-do-i-stop-banshee-remembering-whats-been-played

This patch appears to solve the issue, but I suspect it is not the correct fix and am hoping someone with more experience can chime in.  Thanks!

diff --git a/src/Backends/Banshee.GStreamer/Banshee.GStreamer/PlayerEngine.cs b/src/Backends/Banshee.GStreamer/Banshee.GStreamer/PlayerEngine.cs
index 1fbfcaf..b3ae8bc 100644
--- a/src/Backends/Banshee.GStreamer/Banshee.GStreamer/PlayerEngine.cs
+++ b/src/Backends/Banshee.GStreamer/Banshee.GStreamer/PlayerEngine.cs
@@ -439,7 +439,7 @@ namespace Banshee.GStreamer
             //
             // This will be overridden by IncrementLastPlayed () called by
             // PlaybackControllerService's EndOfStream handler.
-            CurrentTrack.UpdateLastPlayed ();
+            //CurrentTrack.UpdateLastPlayed ();
 
             next_track_set.Reset ();
             pending_uri = null;
Comment 1 Bertrand Lorentz 2013-05-11 09:19:21 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 670833 ***