After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699943 - fix conditionalization of gnome-code-coverage.m4
fix conditionalization of gnome-code-coverage.m4
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-08 17:29 UTC by Dan Winship
Modified: 2013-05-09 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
code-coverage: fix conditionalization (2.33 KB, patch)
2013-05-08 17:30 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2013-05-08 17:29:52 UTC 
see patch
Comment 1 Dan Winship 2013-05-08 17:30:02 UTC 
Created attachment 243607 [details] [review]
code-coverage: fix conditionalization

The "make clean" rule added by gnome-code-coverage.m4 was not
conditionalized (making it spew errors on "make clean" when built
without coverage support, since $(LCOV) expanded to ""), and the other
rules were conditionalized incorrectly (testing "ifdef
CODE_COVERAGE_ENABLED", when that variable was always set, just
sometimes to "no"). Fix both problems.
Comment 2 Philip Withnall 2013-05-09 06:36:13 UTC 
Review of attachment 243607 [details] [review]:

Good catch. Looks fine to commit by me.
Comment 3 Dan Winship 2013-05-09 13:16:28 UTC 
Attachment 243607 [details] pushed as 47e94cb - code-coverage: fix conditionalization