After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699938 - allow skipping all dependencies
allow skipping all dependencies
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-05-08 15:58 UTC by Adam Dingle
Modified: 2013-05-09 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (906 bytes, patch)
2013-05-08 16:02 UTC, Adam Dingle
accepted-commit_now Details | Review

Description Adam Dingle 2013-05-08 15:58:44 UTC
In jhbuild it would be nice if I could optionally skip all dependencies, building only the modules I explicitly list in the 'modules' list in my jhbuildrc.
Comment 1 Adam Dingle 2013-05-08 16:02:18 UTC
Created attachment 243598 [details] [review]
patch

Here's a tiny patch that implements this.  With this change, if 'skip' contains '*' then jhbuild will build only the modules you've explicitly listed in your jhbuildrc.
Comment 2 Colin Walters 2013-05-08 17:17:30 UTC
Review of attachment 243598 [details] [review]:

Err...why wouldn't you just use "buildone" for this?
Comment 3 Adam Dingle 2013-05-08 17:23:09 UTC
There are a couple of reasons:

1.  I want to list a bunch of modules in my jhbuildrc and type 'jhbuild' to build them all, without any of their dependencies.  'jhbuild buildone' can't do that since it requires me to name the modules I want to build.

2. Expanding on point 1, I actually *do* want to build dependencies, but only the ones I've named in my jhbuildrc.  In other words, if my jhbuildrc lists epiphany, webkit and gtk+, then when I type 'jhbuild epiphany' I'd like jhbuild to build all three of those modules in correct dependency order.  But I don't want it to build any of the 27 other dependencies that epiphany would normally bring in.

The attached patch yields exactly this behavior when I include this line in my jhbuildrc:

skip = ['*']
Comment 4 Colin Walters 2013-05-08 17:47:45 UTC
Review of attachment 243598 [details] [review]:

Ok, personally if I am getting to that kind of specialized subset of things I just drive it directly by cd ~/src/module && jhbuild make.  But this is OK as an easter egg...
Comment 5 Adam Dingle 2013-05-08 18:01:20 UTC
OK.  I've already found this pretty useful.  As long as I'm committing this, would you prefer it remain undocumented (i.e. an easter egg) or can I update the jhbuild manual to mention this special skip value?
Comment 6 Colin Walters 2013-05-08 18:56:55 UTC
(In reply to comment #5)
> OK.  I've already found this pretty useful.  As long as I'm committing this,
> would you prefer it remain undocumented (i.e. an easter egg) or can I update
> the jhbuild manual to mention this special skip value?

I honestly don't have a sense of how many other people would find this useful.  If you think they would, please do add it to the manual.
Comment 7 Adam Dingle 2013-05-09 10:18:14 UTC
OK - I documented it.