GNOME Bugzilla – Bug 699884
Don't hard code button heights
Last modified: 2013-05-12 15:53:16 UTC
This commit hard coded the button heights for the play/pause, next, previous and shuffle/repeat buttons: https://git.gnome.org/browse/gnome-music/commit/?id=d4fd52cf03a3ae7e161ef12830ba98373e407b64 We should be relying on the theme to provide the button height, not setting it manually.
Created attachment 243573 [details] [review] change the stringifying function
arg, wrong ticket.
Review of attachment 243573 [details] [review]: Wrong bug
Created attachment 243897 [details] [review] Let button fill the height
This is how it used to be. And the designers changed it because the fill height was too much. :(
Review of attachment 243897 [details] [review]: The patch works for correcting the button sizes , http://img.ctrlv.in.s3.amazonaws.com/img/518f82f22d29c.png , maybe because I am not using jhbuild, the separators are still there for me (although I see they have been chucked off the code) Still needs some jhbuild user for music to test it to be sure. :)
your screenshot does not show the bottom bar. and this is supposed t0 affect the bottom bar. Also when testing and showing screenshot make sure you are using Adwaita
Review of attachment 243897 [details] [review]: As I said this brings us back where we started. The buttons are not too high
(In reply to comment #5) > This is how it used to be. And the designers changed it because the fill height > was too much. :( Ok, so the question is, what is the correct class we should apply to the buttons/playbar? Or even, is there a class fitting our purpose?
Created attachment 243917 [details] prepare playground for Seif's patch