After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699636 - ui: add missing delimiter in GTK-Doc comment block
ui: add missing delimiter in GTK-Doc comment block
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 688897
 
 
Reported: 2013-05-03 21:55 UTC by Dieter Verfaillie
Modified: 2013-05-03 22:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: add missing delimiter in GTK-Doc comment block (1.38 KB, patch)
2013-05-03 21:55 UTC, Dieter Verfaillie 		committed Details | Review

Description Dieter Verfaillie 2013-05-03 21:55:55 UTC 
--warn-error is being passed to g-ir-scanner, which will emite more
warnings regarding broken GTK-Doc comment blocks in the future.

Attached patch fixes the reported issue(s).
Comment 1 Dieter Verfaillie 2013-05-03 21:55:57 UTC 
Created attachment 243250 [details] [review]
ui: add missing delimiter in GTK-Doc comment block

g-ir-scanner will emit more warnings regarding broken GTK-Doc
syntax in the near future, which due to --warn-error being used
would break the build:

'''
ui/theme.c:1883: Warning: Meta: missing ":" at column 20:
 * @tokens_p: (out) The resulting tokens
                   ^
g-ir-scanner: compile: gcc -Wall -Wno-deprecated-declarations ...
g-ir-scanner: link: /bin/sh ../libtool --mode=link --tag=CC gcc ...
libtool: link: gcc -o /home/dieterv/gnome.org/checkout/mutter/...
<unknown>:: Fatal: Meta: warnings configured as fatal
<unknown>:: Fatal: Meta: warnings configured as fatal

make[4]: *** [Meta-3.0.gir] Error 1
'''
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-03 22:02:37 UTC 
Review of attachment 243250 [details] [review]:

OK.
Comment 3 Dieter Verfaillie 2013-05-03 22:25:51 UTC 
Pushed as https://git.gnome.org/browse/mutter/commit/?id=f5e75de3306bf773baffd8bff4e97bfe9bf57fbc

Thanks for the review.