GNOME Bugzilla – Bug 699620
annoying lowercasing
Last modified: 2013-05-20 16:08:05 UTC
when I press shift + a to write upper-case a there is lower-case a written and cursor is moved all the way to the left. Is this because search is case insensitive ? The proper way to implement that is to compare case insensitively, but keep the user input unchanged. In any case, that cursor move is annoying. Steps to Reproduce: 1.start g-d 2.press ctrl+f 3.press shift A 4. wait a sec 5. press shift B Actual results: ba in search field Expected results: I would expect AB there
Created attachment 244766 [details] [review] searchbar: Don't mess with the text input by the user The correct way would be to block/unblock the signal handler, but I could not figure out how to do that in JavaScript so this a workaround.
Review of attachment 244766 [details] [review]: Thanks, looks good with these nitpicks fixed. ::: src/searchbar.js @@ +23,3 @@ const Gdk = imports.gi.Gdk; const GLib = imports.gi.GLib; +const GObject = imports.gi.GObject; Doesn't seem to be needed. @@ +301,3 @@ // connect to search string changes in the controller + this._searchChangedId = Application.searchController.connect('search-string-changed', + Lang.bind(this, this._onSearchStringChanged)); 4-spaces indent for this line and below please.
(In reply to comment #2) > Review of attachment 244766 [details] [review]: > > Thanks, looks good with these nitpicks fixed. > > ::: src/searchbar.js > @@ +23,3 @@ > const Gdk = imports.gi.Gdk; > const GLib = imports.gi.GLib; > +const GObject = imports.gi.GObject; > > Doesn't seem to be needed. Done. > @@ +301,3 @@ > // connect to search string changes in the controller > + this._searchChangedId = > Application.searchController.connect('search-string-changed', > + > Lang.bind(this, this._onSearchStringChanged)); > > 4-spaces indent for this line and below please. Done.
Created attachment 244829 [details] [review] searchbar: Don't mess with the text input by the user
Thanks for the review. Pushed to master and gnome-3-8.