After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699378 - Criticals from cc-common-language
Criticals from cc-common-language
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-01 13:25 UTC by Kalev Lember
Modified: 2013-05-01 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
common: Fix criticals when user language getting fails (973 bytes, patch)
2013-05-01 13:25 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2013-05-01 13:25:09 UTC 
I'm getting criticals when I have the user-accounts panel open and edit the users through other means in the background. This is a really weird corner case, but the fix seems easy enough.

GLib-CRITICAL **: g_variant_get_string: assertion `value != NULL' failed

GLib-CRITICAL **: g_variant_unref: assertion `value != NULL' failed
Comment 1 Kalev Lember 2013-05-01 13:25:41 UTC 
Created attachment 242992 [details] [review]
common: Fix criticals when user language getting fails

Handle the error case when the call to the accountservice dbus proxy
object fails.
Comment 2 Rui Matos 2013-05-01 14:24:04 UTC 
Review of attachment 242992 [details] [review]:

Looks good
Comment 3 Kalev Lember 2013-05-01 14:30:41 UTC 
Attachment 242992 [details] pushed as 29498bb - common: Fix criticals when user language getting fails