After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699337 - v4l2: fix and cleanup VIDIOC_EXPBUF handling
v4l2: fix and cleanup VIDIOC_EXPBUF handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 699382
 
 
Reported: 2013-04-30 15:58 UTC by Michael Olbrich
Modified: 2013-05-01 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.45 KB, patch)
2013-04-30 15:58 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2013-04-30 15:58:17 UTC 
Created attachment 242947 [details] [review]
patch

With this patch VIDIOC_EXPBUF actually works, or a correct warning is printed.
However the whole DMABUF code is currently broken.
V4L2_MEMORY_DMABUF is an alternative to V4L2_MEMORY_USERPTR that can be used to queue other DMABUF file descriptors. To create new DMABUF file descriptors V4L2_MEMORY_MMAP + VIDIOC_EXPBUF must be used. The two modes cannot be mixed.
Right now QBUF fails because the device is configured for MMAP and a DMABUF buffer is queued.
Comment 1 Sebastian Dröge (slomo) 2013-05-01 13:41:41 UTC 
commit eebe5fc70df56762b7f4729c4dbbc87f1748951f
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Tue Apr 30 13:07:37 2013 +0200

    v4l2: fix and cleanup VIDIOC_EXPBUF handling
    
    clear the struct, and provide a correct error message
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699337