Created attachment 242878 [details] [review]
express: Correctly set timezone configuration

The libosinfo API expects a standard timezone string rather than
abbreviations (e.g 'Europe/Helsinki' rather than 'EET') but glib API we
use can only give us abbreviations. This patch fixes the issue by
fetching the timezone string directly from the system.

This issue had so far not been noticed because currently libosinfo sets
timezone for only Fedora and up until Fedora 19, Fedora has been
silently ignoring invalid timezone string we have been providing it. In
Fedora 19 however, express installation breaks: Installation stops with
an error and user is expected to set a valid timezone.

Review of attachment 242878 [details] [review]:

Bleh, complicated :(

::: src/util-app.vala
@@ +483,3 @@
+        } catch (GLib.Error e) {
+            // A system without systemd. :( Lets try the hack'ish way.
+            debug ("Failed to get timezone from systemd.");

I'd add e.message to the debug

Attachment 242878 [details] pushed as e388b83 - express: Correctly set timezone configuration

Created attachment 243065 [details] [review]
util: More error handling in get_timezone_from_linux()

Catch a two more errors, separately.

Comment on attachment 243065 [details] [review]
util: More error handling in get_timezone_from_linux()

Attachment 243065 [details] pushed as dc700ac - util: More error handling in get_timezone_from_linux()