GNOME Bugzilla – Bug 699261
[PATCH] session: Don't accept empty string as saved language
Last modified: 2013-04-29 21:15:09 UTC
This way we get a proper fallback to the system's default locale. Fixes setting of $LANG in user session in gnome-ostree buildmaster. --- daemon/gdm-session.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Created attachment 242845 [details] [review] 0001-session-Don-t-accept-empty-string-as-saved-language.patch
See also: http://lists.freedesktop.org/archives/systemd-devel/2013-January/007945.html for a discussion of the current state of $LANG, pam, systemd, gdm, and accountsservice.
<walters> Jasper, since i'm guessing halfline is busy, care to +1 https://bugzilla.gnome.org/show_bug.cgi?id=699261 ? <Services> Bug 699261: normal, Normal, ---, gdm-maint, UNCONFIRMED, [PATCH] session: Don't accept empty string as saved language <walters> though i still get an ellipsized list in g-i-s by default, but this is a useful first step <Jasper> walters, I'm confused. <Jasper> walters, oh, wait a minute <walters> i think it's accountsservice that's feeding us an empty string instead of NULL <walters> but you never notice this on fedora because of /etc/profile.d/lang.sh <walters> see also http://lists.freedesktop.org/archives/systemd-devel/2013-January/007945.html fwiw <walters> i should add that to the bug <Jasper> walters, yeah, I'm not sure if accountsservice feeding us an empty string because of a blank keyfile is what we want <Jasper> if mclasen was here... <walters> it's probably worth fixing in both places <walters> though i have a minor concern about suddenly returning NULL instead of "" might crash some accountsservice caller that was relying on the previous behavior <Jasper> walters, anyway, I think that's a good patch, but I'd add a lot more to the commit message <walters> like: http://pastebin.mozilla.org/2360345 ? <Jasper> walters, ACK