GNOME Bugzilla – Bug 699176
Option to choose columns that are displayed
Last modified: 2021-05-26 09:51:51 UTC
When a column header is right clicked, a list should appear, so that the user can choose from there which columns should be displayed.
Created attachment 243468 [details] [review] Fixed the Bug added the required feature
Review of attachment 243468 [details] [review]: I do not think that this a good way to solve the bug. The root cause of this problem is that EasyTAG does not have a good way to deal with the problem of choosing which tag fields to display in the UI (neither in the file list nor in the tag view text entries). For this, there needs to be a mapping of tag fields to UI fields, and control of which UI fields should be shown. This is a large and complex issue that is too time-consuming to solve at the moment. This issue blocks progress on several of the open bugs, such as displaying ID3v2 extended fields, custom OGG tag fields and adding new masks to the scanner. Specifically, the problems with this patch is that a popup menu is not the best way to configure this behaviour. It is best to follow the example that Nautilus has for configuring visible columns (Preferences→List columns) as it is unlikely to change this view often. Additionally, the setting should be saved. Nautilus also allows the user to rearrange the order of the columns, and this would be a nice feature, but difficult to implement given the current approach used in EasyTAG. ::: src/bar.c @@ +555,3 @@ +*/ + +void ColPopup_Action_Toggled (GtkToggleAction *action) This should be static, as you do not use it in any other source file. @@ +564,3 @@ + { + column = gtk_tree_view_get_column (GTK_TREE_VIEW (BrowserList), index); + if (strcmp (gtk_label_get_text (GTK_LABEL (gtk_tree_view_column_get_widget (column))), This will only work in English locales, and does not work for languages where the column title is translated.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/easytag/-/issues/ Thank you for your understanding and your help.