GNOME Bugzilla – Bug 699153
display error message when cloning fails
Last modified: 2015-08-08 09:01:08 UTC
To see the problem, choose Clone Repository, then type a URL which does not point to a Git repository, e.g. git://git.gnome.org/xyzzy. gitg will display a message "Cloning..." and the progress spinner will spin briefly. The console will display a warning "** (gitg:25077): WARNING **: gitg-gtk-dash-view.vala:278: error cloning: Early EOF". You'll be left with a repository "xyzzy" in the Projects list which is non-functional: when you click on it nothing happens. Instead, gitg should display a dialog with the error message "error cloning: Early EOF", or with a more user-friendly message such as "Unable to clone remote repository". No new repository should be left in the Projects list.
Cloning is not finished yet, several things are missing and several things need to be discussed on how to handle it: 1) credentials are not handled 2) how do we ask for a credential? 3) how do we show the user an error? 4) cloning is handle in a different thread, so when an error happen do we remove the row from the dash? do we keep it showing the error on the row? etc etc etc...
Sure. My votes: 1) yes, they should be :) 2 and 3) simple dialogs should suffice 4) when an error happens, I think we should pop up a dialog; as soon as the user clicks OK, the failed clone vanishes from the dash
I've pushed a few fixes regarding this. The behavior is: 1. Credentials are asked for in a dialog, as needed 2. On fail, the cloning row is removed directly, an info bar is shown with the error