After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699129 - Clone button should be default in Clone Repository dialog
Clone button should be default in Clone Repository dialog
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-28 12:53 UTC by Adam Dingle
Modified: 2013-04-29 08:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set default button clone at clone widget (2.40 KB, patch)
2013-04-29 07:58 UTC, Jose Manuel Pintor Freire 		needs-work Details | Review
Set default button clone at clone widget (1.83 KB, patch)
2013-04-29 08:19 UTC, Jose Manuel Pintor Freire 		committed Details | Review
Move clone dialog settings to ui (1.57 KB, patch)
2013-04-29 08:25 UTC, Jose Manuel Pintor Freire 		committed Details | Review

Description Adam Dingle 2013-04-28 12:53:01 UTC 
I'm running gitg from git master.

In the Clone Repository dialog, the Clone button should be the default button, so that I can press Enter to activate that button even when the focus is elsewhere.
Comment 1 Jose Manuel Pintor Freire 2013-04-29 07:58:12 UTC 
Created attachment 242776 [details] [review]
Set default button clone at clone widget
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-04-29 08:00:40 UTC 
Review of attachment 242776 [details] [review]:

Patch looks good, although I'm thinking this should be better split into 2 patches. One for what you are fixing and another for moving the modal and resizable to the ui file.
Comment 3 Jose Manuel Pintor Freire 2013-04-29 08:19:01 UTC 
Created attachment 242777 [details] [review]
Set default button clone at clone widget
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-04-29 08:19:59 UTC 
Review of attachment 242777 [details] [review]:

Looks good.
Comment 5 Jose Manuel Pintor Freire 2013-04-29 08:25:16 UTC 
Created attachment 242779 [details] [review]
Move clone dialog settings to ui
Comment 6 Ignacio Casal Quinteiro (nacho) 2013-04-29 08:26:44 UTC 
Comment on attachment 242779 [details] [review]
Move clone dialog settings to ui

Looks good
Comment 7 Ignacio Casal Quinteiro (nacho) 2013-04-29 08:26:52 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.