After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698972 - popupMenu: Allow separator items to have labels
popupMenu: Allow separator items to have labels
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-26 16:40 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2014-01-17 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popupMenu: Allow separator items to have labels (2.99 KB, patch)
2013-04-26 16:40 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-04-26 16:40:50 UTC 
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-04-26 16:40:53 UTC 
Created attachment 242594 [details] [review]
popupMenu: Allow separator items to have labels

This fixes a regression with remote menus where sections have
labels, like gnome-documents.
Comment 2 Giovanni Campagna 2013-04-26 17:29:58 UTC 
Review of attachment 242594 [details] [review]:

Uhm... Gtk section titles don't have a separator next to them.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-05-09 03:32:45 UTC 
(In reply to comment #2)
> Review of attachment 242594 [details] [review]:
> 
> Uhm... Gtk section titles don't have a separator next to them.

https://git.gnome.org/browse/gtk+/tree/gtk/gtkmenushell.c#n2052 says they create a separator menu item with a label. So they should be a separator.