After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698936 - proxy/gnome: Use this in an Ubuntu (Unity) session too.
proxy/gnome: Use this in an Ubuntu (Unity) session too.
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-04-26 10:31 UTC by Iain Lane
Modified: 2013-04-30 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proxy/gnome: Use this in an Ubuntu (Unity) session too. (996 bytes, patch)
2013-04-26 10:31 UTC, Iain Lane
accepted-commit_now Details | Review
proxy/gnome: Use in a Unity session too (1.04 KB, patch)
2013-04-29 17:52 UTC, Iain Lane
committed Details | Review

Description Iain Lane 2013-04-26 10:31:19 UTC
We were seeing loads of pxgsettings processes (strange libproxy design) in a standard session. Turned out to be because glib-networking was falling back to libproxy because of this DESKTOP_SESSION check. We should be OK to use ubuntu here too.
Comment 1 Iain Lane 2013-04-26 10:31:21 UTC
Created attachment 242538 [details] [review]
proxy/gnome: Use this in an Ubuntu (Unity) session too.

This avoids falling back to libproxy unnecessarily.
Comment 2 Dan Winship 2013-04-26 14:55:03 UTC
Comment on attachment 242538 [details] [review]
proxy/gnome: Use this in an Ubuntu (Unity) session too.

looks good. If there is a launchpad bug with discussion of this, could you link to that in the commit message as well?
Comment 3 Iain Lane 2013-04-29 17:52:58 UTC
Created attachment 242829 [details] [review]
proxy/gnome: Use in a Unity session too

Thanks. OK, I added a link to the bug. I can't commit though; perhaps you could?
Comment 4 Dan Winship 2013-04-30 13:31:30 UTC
thanks. fixed in master, will eventually make it into 2.36.2