GNOME Bugzilla – Bug 698863
3.10 - st-icon - missing check for null
Last modified: 2013-05-02 07:52:36 UTC
Created attachment 242432 [details] [review] check if gicon is null before unref. st_icon_set_icon_name check for gicon and priv->gicon equality then unref gicon. If both are null , it fails to unref. else we could return if icon_name is null (which is the case here) as then gicon is always null (and g_themed_icon_new_with_default_fallbacks seems to always return a gicon if icon_name passed is not null).
+ Trace 231851
Review of attachment 242432 [details] [review]: Looks good.
I have pushed this.