After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698778 - chat entry not focused on expand
chat entry not focused on expand
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 698885 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-24 18:27 UTC by William Jon McCann
Modified: 2013-06-21 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Ensure notifications are focused after they are expanded (1.62 KB, patch)
2013-06-21 19:26 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description William Jon McCann 2013-04-24 18:27:58 UTC 
The chat notifications are a bit harder to use now because the entry isn't focused when I expand the banner. It seems to me like it probably should.
Comment 1 Jakub Steiner 2013-04-26 14:36:54 UTC 
*** Bug 698885 has been marked as a duplicate of this bug. ***
Comment 2 Michael Monreal 2013-06-01 21:21:14 UTC 
To make things worse, if you miss the actual text entry when clicking for focus and hit the rest of the notification bubble instead the chat will open in an empty empathy window and the chat messages will be lost!
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-06-21 19:26:52 UTC 
Created attachment 247488 [details] [review]
messageTray: Ensure notifications are focused after they are expanded

If we focus notifications before they're expanded, the body and action
area won't be visible, and the can_focus members like the text entry
will not be able to be focused.

Ensure that all of the all actors that would be in an expanded notification
are visible before we attempt to focus them.
Comment 4 drago01 2013-06-21 19:28:57 UTC 
Review of attachment 247488 [details] [review]:

Makes sense, didn't test it though fine to push assuming you tested it and it works.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-06-21 19:32:47 UTC 
Attachment 247488 [details] pushed as aa7ed31 - messageTray: Ensure notifications are focused after they are expanded


Yeah, I did test it.