After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698444 - Don't build tests until needed
Don't build tests until needed
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
3.8.x
Other Linux
: Normal minor
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-20 12:12 UTC by Pacho Ramos
Modified: 2013-05-21 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build-tests.patch (2.99 KB, patch)
2013-04-20 12:12 UTC, Pacho Ramos 		none Details | Review

Description Pacho Ramos 2013-04-20 12:12:34 UTC 
Created attachment 241985 [details] [review]
build-tests.patch

We are applying attached patch on Gentoo for some time, would be nice to get it upstreamed

Thanks
Comment 1 Martin Pitt 2013-04-22 05:41:07 UTC 
That looks fine, thanks. I pushed this with an updated commit log to https://git.gnome.org/browse/pygobject/commit/?id=8d61ad38e

I also dropped the LC_ALL setting; test_gi.py already does that, so I believe this is redundant. If you still get test failures under different locales, please file another upstream bug, I'd like to investigate this. I don't get any under C or de_DE.UTF-8.
Comment 2 Pacho Ramos 2013-05-13 18:25:34 UTC 
Could this be also committed to 3.8 branch?
Comment 3 Martin Pitt 2013-05-21 12:46:45 UTC 
TBH I don't like build system changes for stable releases. This is by far not an important bug, and it might disrupt/confuse packages for other distributions.