After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698287 - Make sure wizard buttons use underlined chars
Make sure wizard buttons use underlined chars
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-18 11:15 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make sure wizard buttons use underlined chars (2.44 KB, patch)
2013-04-18 11:15 UTC, Christophe Fergeau 		accepted-commit_now Details | Review
Make sure wizard buttons use underlined chars (1.50 KB, patch)
2013-04-18 11:39 UTC, Christophe Fergeau 		none Details | Review
Make sure wizard buttons use underlined chars (2.34 KB, patch)
2013-04-18 11:44 UTC, Christophe Fergeau 		committed Details | Review
Fix underline char in "Done" selection button (1.10 KB, patch)
2013-04-23 11:38 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2013-04-18 11:15:05 UTC 
For some reason, creating a button with a label containing a "_"
and setting use_underline to TRUE afterwards don't make GtkButton
reinterpret the label to remove the '_' character from the label
and use it as an underline mark.
Setting the label to the value it already has right after setting
use_underline works around this issue.
Things seem to work as expected with gtk+ 3.6 without this workaround
so it's likely to be a gtk+ regression.
Comment 1 Christophe Fergeau 2013-04-18 11:15:08 UTC 
Created attachment 241815 [details] [review]
Make sure wizard buttons use underlined chars
Comment 2 Christophe Fergeau 2013-04-18 11:35:18 UTC 
This is actually a libgd bug, see bug #698289
Comment 3 Christophe Fergeau 2013-04-18 11:39:14 UTC 
Created attachment 241817 [details] [review]
Make sure wizard buttons use underlined chars

Because of libgd bgo#698289, creating a button with a label containing a
"_" and setting use_underline to TRUE afterwards don't make
GdHeadersimpleButton reinterpret the label to remove the '_' character
and use it as an underline mark.

Setting the label to the value it already has right after setting
use_underline works around this issue.
Comment 4 Christophe Fergeau 2013-04-18 11:44:10 UTC 
Created attachment 241818 [details] [review]
Make sure wizard buttons use underlined chars

Because of libgd bgo#698289, creating a button with a label containing a
"_" and setting use_underline to TRUE afterwards don't make
GdHeadersimpleButton reinterpret the label to remove the '_' character
and use it as an underline mark.

Setting the label to the value it already has right after setting
use_underline works around this issue.
Comment 5 Zeeshan Ali 2013-04-18 13:30:55 UTC 
Review of attachment 241815 [details] [review]:

ACK with 1 micro change: Please add a FIXME note pointing to bug#698289.
Comment 6 Christophe Fergeau 2013-04-18 14:55:58 UTC 
Attachment 241818 [details] pushed as 41e9cb5 - Make sure wizard buttons use underlined chars
Comment 7 Christophe Fergeau 2013-04-23 11:38:02 UTC 
Created attachment 242206 [details] [review]
Fix underline char in "Done" selection button

In commit "Make sure wizard buttons use underlined chars", I missed
the "Done" button which exits from the selection mode. This commit
fixes it.
Comment 8 Zeeshan Ali 2013-04-23 12:43:53 UTC 
Review of attachment 242206 [details] [review]:

ACK
Comment 9 Christophe Fergeau 2013-04-23 17:43:46 UTC 
Comment on attachment 242206 [details] [review]
Fix underline char in "Done" selection button

Attachment 242206 [details] pushed as 01b104c - Fix underline char in "Done" selection button