GNOME Bugzilla – Bug 698169
classic mode: not enough bottom margin for window list
Last modified: 2013-05-13 20:09:43 UTC
Created attachment 241695 [details] Screenshot of GNOME Classic GNOME Shell 3.8.1 "Classic mode" on Ubuntu 13.04 The window list buttons look like they're cut off at the bottom. I think it just needs some margin on the bottom. Compare with gnome-panel. Screenshots attached.
Created attachment 241696 [details] Screenshot of GNOME panel
Florian, can we fix this ? It is very visible
Created attachment 242946 [details] [review] window-list: Make bottom panel taller in classic mode Consider additional borders in classic styling for the panel height.
Review of attachment 242946 [details] [review]: I'm not fully sure what's going on but the panel comes up 33px tall and thus you can't activate the buttons if the pointer is on the bottom pixel row. Just setting the !important on stylesheet.css instead of overriding this new one here seems to make it work correctly. i.e. diff --git a/extensions/window-list/stylesheet.css b/extensions/window-list/stylesheet.css index 330e99e..12b6fed 100644 --- a/extensions/window-list/stylesheet.css +++ b/extensions/window-list/stylesheet.css @@ -2,7 +2,7 @@ /* .window-button-icon height + .window-button vertical padding + .window-button > StWidget vertical padding) */ - height: 30px; + height: 30px !important; }
(In reply to comment #4) > I'm not fully sure what's going on but the panel comes up 33px tall and thus > you can't activate the buttons if the pointer is on the bottom pixel row. Odd, I tested that explicitly and it works fine here. > Just setting the !important on stylesheet.css instead of overriding this new > one here seems to make it work correctly. i.e. Huh, interesting. It comes out a bit cramped to my taste, but as there's not conflicting CSS that is overwritten, it's interesting that it makes a difference in the first place.
I think I found the real problem. When the summary-source-counter is visible, its size makes the window-buttons shift down and that's probably why it worked for you. So, to keep the 32px panel height and still have the window-buttons always fill up that height we need to increase the padding on them: + padding: 4px 6px 2px !important;
Attachment 242946 [details] pushed as 45767c9 - window-list: Make bottom panel taller in classic mode (In reply to comment #6) > So, to keep the 32px panel height and still have the window-buttons always fill > up that height we need to increase the padding on them: > > + padding: 4px 6px 2px !important; Works fine in testing, pushing.