After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698123 - Is required to translate names of element/attribute/button?
Is required to translate names of element/attribute/button?
Status: RESOLVED NOTABUG
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-16 11:41 UTC by Ján Kyselica
Modified: 2013-09-26 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ján Kyselica 2013-04-16 11:41:46 UTC
Is required to translate names of element/attribute/button or these strings are of internal use that aren't too important?

In these strings there are words type and style_set:

#: ../src/ui/theme-parser.c:1264
#, c-format
msgid "Unknown type \"%s\" on <%s> element"
msgstr ""

#: ../src/ui/theme-parser.c:1275
#, c-format
msgid "Unknown style_set \"%s\" on <%s> element"
msgstr ""

Button_width, button_height, aspect_ratio

#: ../src/ui/theme-parser.c:1427
#: ../src/ui/theme-parser.c:1441
#: ../src/ui/theme-parser.c:1486
msgid "Cannot specify both \"button_width\"/\"button_height\" and \"aspect_ratio\" for buttons"
msgstr ""

draw_ops

#: ../src/ui/theme-parser.c:2706
#: ../src/ui/theme-parser.c:2802
#, c-format
msgid "Including draw_ops \"%s\" here would create a circular reference"
msgstr ""

name/author/date/description

#: ../src/ui/theme-parser.c:3582
#, c-format
msgid "Element <%s> is not allowed inside a name/author/date/description element"
msgstr ""

distance/border/aspect_ratio

#: ../src/ui/theme-parser.c:3599
#, c-format
msgid "Element <%s> is not allowed inside a distance/border/aspect_ratio element"
msgstr ""

open

#: ../src/ui/theme-viewer.c:117
msgid "This is a demo button with an 'open' icon"
msgstr ""

quit

#: ../src/ui/theme-viewer.c:119
msgid "This is a demo button with a 'quit' icon"
msgstr ""
Comment 1 Pavol Klačanský 2013-09-22 17:38:24 UTC
any devs, please?
Comment 2 Pavol Klačanský 2013-09-22 18:01:46 UTC
There shoud be no space at the end

#: ../src/core/util.c:264
msgid "Window manager: "

#: ../src/core/util.c:414
msgid "Bug in window manager: "
#: ../src/core/util.c:445
msgid "Window manager warning: "

#: ../src/core/util.c:473
msgid "Window manager error: "
Comment 3 Owen Taylor 2013-09-23 17:38:04 UTC
(In reply to comment #2)
> There shoud be no space at the end
> 
> #: ../src/core/util.c:264
> msgid "Window manager: "
> 
> #: ../src/core/util.c:414
> msgid "Bug in window manager: "
> #: ../src/core/util.c:445
> msgid "Window manager warning: "
> 
> #: ../src/core/util.c:473
> msgid "Window manager error: "

No, these are correct as is.
Comment 4 Owen Taylor 2013-09-23 17:44:06 UTC
(In reply to comment #0)
> Is required to translate names of element/attribute/button or these strings are
> of internal use that aren't too important?
> 
> In these strings there are words type and style_set:
> 
> #: ../src/ui/theme-parser.c:1264
> #, c-format
> msgid "Unknown type \"%s\" on <%s> element"
> msgstr ""
> 
> #: ../src/ui/theme-parser.c:1275
> #, c-format
> msgid "Unknown style_set \"%s\" on <%s> element"
> msgstr ""
> 
> Button_width, button_height, aspect_ratio
> 
> #: ../src/ui/theme-parser.c:1427
> #: ../src/ui/theme-parser.c:1441
> #: ../src/ui/theme-parser.c:1486
> msgid "Cannot specify both \"button_width\"/\"button_height\" and
> \"aspect_ratio\" for buttons"
> msgstr ""
> 
> draw_ops
> 
> #: ../src/ui/theme-parser.c:2706
> #: ../src/ui/theme-parser.c:2802
> #, c-format
> msgid "Including draw_ops \"%s\" here would create a circular reference"
> msgstr ""
> 
> name/author/date/description
> 
> #: ../src/ui/theme-parser.c:3582
> #, c-format
> msgid "Element <%s> is not allowed inside a name/author/date/description
> element"
> msgstr ""
> 
> distance/border/aspect_ratio
> 
> #: ../src/ui/theme-parser.c:3599
> #, c-format
> msgid "Element <%s> is not allowed inside a distance/border/aspect_ratio
> element"
> msgstr ""
> 
> open
> 
> #: ../src/ui/theme-viewer.c:117
> msgid "This is a demo button with an 'open' icon"
> msgstr ""
> 
> quit
> 
> #: ../src/ui/theme-viewer.c:119
> msgid "This is a demo button with a 'quit' icon"
> msgstr ""

While these strings aren't very important strings from the point of view o an average - translating them is consistent with what we do elsewhere in Mutter. 

These aren't in things we're actively changing, they've been marked for a long time, so since we already have pretty good coverage - it doesn't make sense to me to unmark them for translation now.
Comment 5 Pavol Klačanský 2013-09-26 09:31:00 UTC
(In reply to comment #3)
> No, these are correct as is.

Why is space there? why is the space translatable? is it really necessary?

(In reply to comment #4)
> While these strings aren't very important strings from the point of view o an
> average - translating them is consistent with what we do elsewhere in Mutter. 
> 
> These aren't in things we're actively changing, they've been marked for a long
> time, so since we already have pretty good coverage - it doesn't make sense to
> me to unmark them for translation now.

You probably misunderstood. We asked, if the specific parts of strings should be translated or if they are some fixed constants used elsewhere.

E.g. "name/author/date/description" is there element called "name" or it is just description of element and not some hard coded name/constant elewhere

Thank you