GNOME Bugzilla – Bug 698119
Link to mouse panel fix introduces alignment problems
Last modified: 2013-07-15 16:42:19 UTC
See comment in https://bugzilla.gnome.org/show_bug.cgi?id=688469#c8
Created attachment 241637 [details] [review] patch to fix the bug These problems are related to the size that the tablet's image widget took from the patch in the related issue. I think that the reasoning was to make the image occupy the whole vertical space of the grid by making its height prop equal the number of rows but then we got this effect. This new patch sets the image's height to 2 rows making it fully visible but with IMO a decent gap between the styli's settings and the tablet's. Funny enough, setting the height to 2 will produce a smaller gap than before the problematic patch had been applied whereas setting it to 3 will produce a bigger gap...
Created attachment 241638 [details] Comparison between the gaps This screenshot shows the difference between the settings before the "problematic" patch was applied (image in the background) and this new patch, image in the foreground.
This isn't the problem (even if your patch probably is correct). The problem is the ton of whitespace at the bottom of the panel, and all the settings squashed together. Let me put a screenshot together.
Created attachment 242148 [details] bug It's not as visible as I remember it being, but the stylus section should stay aligned when cycling through the tablets, and avoid squishing all the controls at the top of the panel for the shortest sections, and leaving white space at the bottom.
That happens because the first page has more things stacked in the top controls. I can probably vertically align the stylus notebook to always be pushed to the bottom of its area but that'll leave a bigger gap between it and the top controls as the window size will remain the same. If you think this is more acceptable let me know and I'll do it.
The stylus sections should be aligned from one tablet page to the next. Pushed down to the bottom of the page is not good enough. That might require quite a bit of surgery, though sizegroups for each tablet section might be enough to fix this.
I am trying to sort out how to accomplish this. I think I need to change how the page is composed because right now, applying the size group to the main-controls-grid is not doing the trick. This issue was already present before this patch so I believe we should commit this and deal with it in a separate bug.
Hi again Bastien, I think I confused the status of this bug from the one it came from. While it's true that before this patch the stylus settings behaved the exact same way as now, committing the patch attached to this bug doesn't obviously fix the problem you specified before so ignore my previous comment and let's try to correct this if it is really an issue.
(In reply to comment #8) > Hi again Bastien, > > I think I confused the status of this bug from the one it came from. While it's > true that before this patch the stylus settings behaved the exact same way as > now, committing the patch attached to this bug doesn't obviously fix the > problem you specified before so ignore my previous comment and let's try to > correct this if it is really an issue. The patch is fine to commit, the original bug is still there though.
Review of attachment 241637 [details] [review]: As per comment,