After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698091 - fix printf format
fix printf format
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-streaming-server
git master
Other Linux
: Normal normal
: 1.0.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-15 22:09 UTC by Nicola
Modified: 2013-05-11 17:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix printf format (2.84 KB, patch)
2013-04-15 22:09 UTC, Nicola 		none Details | Review
alternate patch (3.58 KB, patch)
2013-04-15 22:36 UTC, Nicola 		none Details | Review

Description Nicola 2013-04-15 22:09:15 UTC 
Created attachment 241598 [details] [review]
fix printf format

patch attached
Comment 1 Tim-Philipp Müller 2013-04-15 22:24:23 UTC 
Looks fine, but I don't understand why the code here does

s = g_strdup_printf (...)
GST_DEBUG_OBJECT (obj, "%s", s);
g_free (s);

instead of just

GST_DEBUG_OBJECT (obj, "....", ...);

David?
Comment 2 Nicola 2013-04-15 22:36:45 UTC 
Created attachment 241601 [details] [review]
alternate patch
Comment 3 David Schleef 2013-04-15 22:40:17 UTC 
I already fixed this locally.  It was previously doing the g_strdup_printf() because it was automatically converted from an older logging system.


commit 1c0073c4d64dfb336e8215e61ee3a48ebedbdac5
Author: David Schleef <ds@schleef.org>
Date:   Sun Apr 14 21:56:11 2013 -0700

    Fix bad debugging printf formats