After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698055 - Support GtkTreeFilterModels in GdMainView
Support GtkTreeFilterModels in GdMainView
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgd maintainer(s)
Depends on:
Blocks: 698053
 
 
Reported: 2013-04-15 11:34 UTC by Alexander Larsson
Modified: 2013-04-15 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GdMainView: Support GtkTreeFilterModels (3.33 KB, patch)
2013-04-15 11:35 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2013-04-15 11:34:46 UTC 
GdMainViewGeneric has some code to handle model being a filter model, but GdMainView doesn't, so it breaks when boxes tries to use it.
Comment 1 Alexander Larsson 2013-04-15 11:35:51 UTC 
Created attachment 241557 [details] [review]
GdMainView: Support GtkTreeFilterModels

Like GdMainViewGeneric we handle GtkTreeFilterModel models by just
looking inside them when setting "selected".
Comment 2 Alexander Larsson 2013-04-15 11:56:59 UTC 
This is required for boxes (bug 698053)
Comment 3 Cosimo Cecchi 2013-04-15 14:02:23 UTC 
Review of attachment 241557 [details] [review]:

Looks good, thanks!
Comment 4 Alexander Larsson 2013-04-15 14:23:30 UTC 
Attachment 241557 [details] pushed as 2fb32d9 - GdMainView: Support GtkTreeFilterModels