After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698016 - Register to Treeview - Trading accounts with other changes.
Register to Treeview - Trading accounts with other changes.
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Register
2.5.x
Other Linux
: Normal enhancement
: ---
Assigned To: Christian Stimming
Geert Janssens
Depends on:
Blocks: 673193
 
 
Reported: 2013-04-14 19:18 UTC by Bob
Modified: 2018-06-29 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Register patch 18 (123.68 KB, patch)
2013-04-14 19:18 UTC, Bob 		committed Details | Review

Description Bob 2013-04-14 19:18:07 UTC 
Created attachment 241519 [details] [review]
Register patch 18

This is an update to the Possible Register migration to Treeview - 673193

As before, do not open same account register in old style and the tree-view one
and it may also be required to delete the saved pages in gconf under register2
heading.

This update adds the trading accounts option. Also included is a fix for the way the model is loaded, it was being loaded twice and changes to the way the view gets refreshed. There are also some minor changes to transaction confirmation. Two new files have been added and some functions moved to these with more to follow.
Comment 1 Geert Janssens 2013-04-20 16:50:13 UTC 
Comment on attachment 241519 [details] [review]
Register patch 18

Committed in r22920, thank you very much.

Note that I have only done a cursory check of the patch as I don't use trading accounts myself.

The patch builds and runs fine. Light testing of the register 2 still works. Others are welcome to stress test the trading accounts and report possible problems.
Comment 2 Bob 2013-04-25 21:32:57 UTC 
I do not use them either but I seem to get the same visually as the existing register.
Comment 3 Geert Janssens 2013-05-02 12:23:58 UTC 
Closing the report as no other feedback was given. If there are still bugs in the new code, I suspect we'll see new bugreports for them appear soon enough.
Comment 4 John Ralls 2018-06-29 23:14:54 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=698016. Please update any external references or bookmarks.