After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697722 - st-im-text: Override ClutterText's cursor_event to set cursor position
st-im-text: Override ClutterText's cursor_event to set cursor position
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-10 14:36 UTC by Rui Matos
Modified: 2013-04-10 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-im-text: Override ClutterText's cursor_event to set cursor position (3.43 KB, patch)
2013-04-10 14:36 UTC, Rui Matos
none Details | Review
st-im-text: Override ClutterText's cursor_event to set cursor position (3.41 KB, patch)
2013-04-10 14:53 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2013-04-10 14:36:53 UTC
See patch.
Comment 1 Rui Matos 2013-04-10 14:36:56 UTC
Created attachment 241166 [details] [review]
st-im-text: Override ClutterText's cursor_event to set cursor position

This is both more efficient and accurate than doing it from the paint
vfunc.
Comment 2 Rui Matos 2013-04-10 14:53:29 UTC
Created attachment 241170 [details] [review]
st-im-text: Override ClutterText's cursor_event to set cursor position

--

* Stop rounding the width/height since those are integers already.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-04-10 15:25:34 UTC
Review of attachment 241170 [details] [review]:

OK.
Comment 4 Rui Matos 2013-04-10 15:29:36 UTC
Attachment 241170 [details] pushed as 86c92c3 - st-im-text: Override ClutterText's cursor_event to set cursor position