After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697721 - PATCH: sushi fails to preview pdf files ( fix content_type to mime )
PATCH: sushi fails to preview pdf files ( fix content_type to mime )
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: libsushi
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-10 14:20 UTC by Philippe "RzR" Coval
Modified: 2013-04-10 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-fix-unref-object-after-using-a-value-this-break-pdf-.patch (861 bytes, patch)
2013-04-10 14:20 UTC, Philippe "RzR" Coval 		committed Details | Review

Description Philippe "RzR" Coval 2013-04-10 14:20:56 UTC 
Created attachment 241162 [details] [review]
0001-fix-unref-object-after-using-a-value-this-break-pdf-.patch

Hi

Observed sushi is not viewing pdf files using evince
but libre office (and displays the binary contents... )

So I dig into the source and noticed the content type is set to random junk
and fails to compare to "application/pdf"

So here is a patch to fix this issue and to work as expected
Comment 1 Cosimo Cecchi 2013-04-10 14:34:58 UTC 
Review of attachment 241162 [details] [review]:

Thanks! Looks good to me; do you have a GNOME git account? Otherwise I will push it to master for you.
Comment 2 Philippe "RzR" Coval 2013-04-10 16:14:44 UTC 
no git account yet , may be I should get one :)

Thank you for pushing it to master 

Regards
Comment 3 Cosimo Cecchi 2013-04-10 17:02:40 UTC 
OK, pushed to master, closing.