After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697714 - Add "photos-icon-bg" style class
Add "photos-icon-bg" style class
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-10 13:44 UTC by Debarshi Ray
Modified: 2013-04-11 19:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
With #000000 (744.63 KB, image/png)
2013-04-10 13:44 UTC, Debarshi Ray 		  Details
With #0000CC (744.76 KB, image/png)
2013-04-10 13:46 UTC, Debarshi Ray 		  Details
gtk3: Add "photos-icon-bg" style class (851 bytes, patch)
2013-04-11 18:48 UTC, Debarshi Ray 		accepted-commit_now Details | Review
gtk3: Add "photos-icon-bg" style class (852 bytes, patch)
2013-04-11 19:07 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-04-10 13:44:56 UTC 
Created attachment 241154 [details]
With #000000

Till now gnome-photos was using documents-icon-bg for the emblems representing favourites, etc.. It looks ugly because with the dark theme it leads to a dark grey emblem on a blue background.

Instead we (or jimmac) wants a plain white emblem with a icon-shadow.

So we need something like this in gnome-applications.css:

/* gnome-photos */

.photos-icon-bg {
  icon-shadow: 0 1px #000000
}

I am not sure what the colour should be. Attaching a couple of screenshots with different values.
Comment 1 Debarshi Ray 2013-04-10 13:46:37 UTC 
Created attachment 241155 [details]
With #0000CC
Comment 2 Debarshi Ray 2013-04-10 13:52:38 UTC 
gnome-photos Git master uses "photos-icon-bg", so all that you need to test it is to make the necessary changes in the theme.
Comment 3 Debarshi Ray 2013-04-11 18:46:21 UTC 
From #gnome-design:

14:46 <cosimoc> rishi, hey
14:47 <cosimoc> rishi, I think the black shadow looks better
14:48 <rishi> cosimoc: Ok. I'll write a patch.
14:48 <rishi> cosimoc: Will need a similar patch forthe collection icons.
14:48 <cosimoc> rishi, yeah
14:49 <cosimoc> rishi, even though I'm kinda wondering whether we should use    
      the same style class and just theme it differently under the dark theme
14:49 <cosimoc> I mean, if someone uses the dark theme for every application,   
      Documents will have the same problem
14:49 <cosimoc> not a very important case, but if we can make it work why not
14:50 <rishi> cosimoc: True, but does documents want the icon-shadow?
14:50 <cosimoc> not sure yeah
14:51 <cosimoc> rishi, let's go with your proposed approach for now
Comment 4 Debarshi Ray 2013-04-11 18:48:23 UTC 
Created attachment 241293 [details] [review]
gtk3: Add "photos-icon-bg" style class
Comment 5 Cosimo Cecchi 2013-04-11 18:56:34 UTC 
Review of attachment 241293 [details] [review]:

Looks good, except for this minor nit.

::: themes/Adwaita/gtk-3.0/gnome-applications.css
@@ +703,3 @@
+
+.photos-icon-bg {
+  icon-shadow: 0 1px #000000

Missing semicolon
Comment 6 Debarshi Ray 2013-04-11 19:07:45 UTC 
Created attachment 241296 [details] [review]
gtk3: Add "photos-icon-bg" style class
Comment 7 Debarshi Ray 2013-04-11 19:08:19 UTC 
Comment on attachment 241296 [details] [review]
gtk3: Add "photos-icon-bg" style class

Thanks for the review.