After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697694 - watchdog: race causing deadlock in stop
watchdog: race causing deadlock in stop
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-10 09:09 UTC by Alexander Schrab
Modified: 2013-04-10 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.72 KB, patch)
2013-04-10 09:09 UTC, Alexander Schrab 		committed Details | Review

Description Alexander Schrab 2013-04-10 09:09:27 UTC 
Created attachment 241128 [details] [review]
Patch

In some cases I get a race between g_main_loop_run (in the thread started in start) and g_main_loop_quit (in stop) that causes the main loop to continue running and thus stop failing to return.
Comment 1 Alexander Schrab 2013-04-10 09:10:21 UTC 
Fixed by replacing the g_main_loop_quit with an idle event calling quit (thus making sure that they are called in the correct order)
Comment 2 Tim-Philipp Müller 2013-04-10 10:09:16 UTC 
Thanks!

 commit 3320f29a88df3a90aa4556fca5f08a738f34a8c9
 Author: Alexander Schrab <alexas@axis.com>
 Date:   Wed Apr 10 11:06:52 2013 +0200

    watchdog: race between g_main_loop_run/_quit fixed
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697694