After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697574 - Only use EGL code paths conditionally if gstreamer-egl is available
Only use EGL code paths conditionally if gstreamer-egl is available
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-08 16:49 UTC by Tim-Philipp Müller
Modified: 2014-07-23 08:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check properly for gstreamer-egl and use for RPi-target if available (9.70 KB, patch)
2013-04-08 16:49 UTC, Tim-Philipp Müller 		needs-work Details | Review

Description Tim-Philipp Müller 2013-04-08 16:49:50 UTC 
Created attachment 240963 [details] [review]
Check properly for gstreamer-egl and use for RPi-target if available

Not sure if there was a reason it wasn't done like this in the first place, or if the fallback cases still work, so just attaching it to bugzilla for now.
Comment 1 Sebastian Dröge (slomo) 2013-04-09 18:09:12 UTC 
Comment on attachment 240963 [details] [review]
Check properly for gstreamer-egl and use for RPi-target if available

Looks good but this should be done only for #if defined(USE_OMX_TARGET_RPI) && defined(HAVE_GST_EGL)

The EGL code is RPi specific
Comment 2 Tim-Philipp Müller 2013-04-23 11:13:34 UTC 
Ok, changed as requested (haven't tried on rpi yet though):

 commit a2db76b048db278ef0aa798e106b7594264e06c0
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Mon Apr 8 17:26:16 2013 +0100

    Check for gstreamer-egl
    
    And don't use if not available.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697574