After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697504 - Fix thumbnail dragging in the overview
Fix thumbnail dragging in the overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.8.1
Depends on:
Blocks:
 
 
Reported: 2013-04-07 19:01 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-04-08 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dnd: Set the scale on the drag actor (1.24 KB, patch)
2013-04-07 19:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dnd: Set the position and scale on the drag actor before it's reparented (1.96 KB, patch)
2013-04-07 19:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-04-07 19:01:40 UTC 
The DND framework was just busted here. See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-04-07 19:01:43 UTC 
Created attachment 240900 [details] [review]
dnd: Set the scale on the drag actor

The actor is the same as the drag actor in this case, but we tend to
set properties on the drag actor and get them from the actor elsewhere
in this codepath. Make this consistent.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-07 19:01:47 UTC 
Created attachment 240901 [details] [review]
dnd: Set the position and scale on the drag actor before it's reparented

We need to do this to ensure that it gets the correct scale, as otherwise
the transform that we retrieve will be incorrect.
Comment 3 drago01 2013-04-08 18:51:48 UTC 
Review of attachment 240900 [details] [review]:

LG.
Comment 4 drago01 2013-04-08 18:52:15 UTC 
Review of attachment 240901 [details] [review]:

Makes sense.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-04-08 18:58:15 UTC 
Attachment 240900 [details] pushed as 5e6a25c - dnd: Set the scale on the drag actor
Attachment 240901 [details] pushed as 4fb33c9 - dnd: Set the position and scale on the drag actor before it's reparented