After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697467 - deinterlace: mode=interlaced doesn't force deinterlacing
deinterlace: mode=interlaced doesn't force deinterlacing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-06 23:49 UTC by Matej Knopp
Modified: 2013-04-07 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (904 bytes, patch)
2013-04-06 23:50 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2013-04-06 23:49:43 UTC 
setting mode to 1 doesn't do anything
Comment 1 Matej Knopp 2013-04-06 23:50:04 UTC 
Created attachment 240868 [details] [review]
Patch
Comment 2 Tim-Philipp Müller 2013-04-07 11:31:07 UTC 
Comment on attachment 240868 [details] [review]
Patch

>   interlacing_mode = GST_VIDEO_INFO_INTERLACE_MODE (&frame->info);
>+  if (self->mode == GST_DEINTERLACE_MODE_INTERLACED)
>+    interlacing_mode = GST_VIDEO_INTERLACE_MODE_INTERLEAVED;

Shouldn't we only override this if the input video is signalled as not interlaced at all?
Comment 3 Matej Knopp 2013-04-07 11:59:56 UTC 
right, i guess this shouldn't be done for mixed mode
Comment 4 David Schleef 2013-04-07 18:33:27 UTC 
I would expect that "Force deinterlacing" would force deinterlacing in all cases.
Comment 5 Tim-Philipp Müller 2013-04-07 22:36:57 UTC 
I was confused about mixed mode, sorry.

Pushed:

 commit 67c22196871b064182273b44b246d48711297eeb
 Author: Matej Knopp <matej.knopp@gmail.com>
 Date:   Sun Apr 7 01:47:56 2013 +0200

    deinterlace: force deinterlacing in "interlaced" mode
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697467