After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697432 - gnome-shell throws traceback if bg menu is open when background menu changes
gnome-shell throws traceback if bg menu is open when background menu changes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-06 14:38 UTC by Ray Strode [halfline]
Modified: 2013-04-06 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popupMenu: close menu on destroy (1.65 KB, patch)
2013-04-06 14:38 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-04-06 14:38:31 UTC 
I see this traceback if i have a background menu open when the background changes

    JS ERROR: !!!   Exception in callback for signal: destroy
    JS ERROR: !!!     message = '"menu is undefined"'
    JS ERROR: !!!     fileName = '"/usr/share/gnome-shell/js/ui/popupMenu.js"'
    JS ERROR: !!!     lineNumber = '2187'
    JS ERROR: !!!     stack = '"PopupMenuManager<._closeMenu@/usr/share/gnome-shell/js/ui/popupMenu.js:2187
wrapper@/usr/share/gjs-1.0/lang.js:213
PopupMenuManager<.removeMenu@/usr/share/gnome-shell/js/ui/popupMenu.js:2090
wrapper@/usr/share/gjs-1.0/lang.js:213
PopupMenuManager<._onMenuDestroy@/usr/share/gnome-shell/js/ui/popupMenu.js:2170
wrapper@/usr/share/gjs-1.0/lang.js:213
_emit@/usr/share/gjs-1.0/signals.js:124
PopupMenuBase<.destroy@/usr/share/gnome-shell/js/ui/popupMenu.js:1163
wrapper@/usr/share/gjs-1.0/lang.js:213
@/usr/share/gnome-shell/js/ui/backgroundMenu.js:60
BackgroundManager<._updateBackground/newBackground.loadedSignalId</<.onComplete<@/usr/share/gnome-shell/js/ui/background.js:752
params[name]@/usr/share/gnome-shell/js/ui/tweener.js:113
_callOnFunction@/usr/share/gjs-1.0/tweener/tweener.js:202
_updateTweenByIndex@/usr/share/gjs-1.0/tweener/tweener.js:332
_updateTweens@/usr/share/gjs-1.0/tweener/tweener.js:344
_onEnterFrame@/usr/share/gjs-1.0/tweener/tweener.js:359
_emit@/usr/share/gjs-1.0/signals.js:124
ClutterFrameTicker<._onNewFrame@/usr/share/gnome-shell/js/ui/tweener.js:253
wrapper@/usr/share/gjs-1.0/lang.js:213
ClutterFrameTicker<._init/<@/usr/share/gnome-shell/js/ui/tweener.js:228
"'
Comment 1 Ray Strode [halfline] 2013-04-06 14:38:34 UTC 
Created attachment 240840 [details] [review]
popupMenu: close menu on destroy

This fixes a crash if a background menu is open
and the background changes.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-06 14:39:31 UTC 
Review of attachment 240840 [details] [review]:

OK.
Comment 3 Ray Strode [halfline] 2013-04-06 14:47:27 UTC 
Attachment 240840 [details] pushed as 77d3712 - popupMenu: close menu on destroy