After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697428 - file browser: don't show libtool files (.lo/.la) when hiding binary files
file browser: don't show libtool files (.lo/.la) when hiding binary files
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on: 702332
Blocks:
 
 
Reported: 2013-04-06 13:10 UTC by Adam Dingle
Modified: 2019-03-23 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bug 697428 - Add binary-patterns setting to the file browser (9.49 KB, patch)
2013-06-16 11:49 UTC, Garrett Regier
committed Details | Review

Description Adam Dingle 2013-04-06 13:10:43 UTC
When I'm filtering out binary files in the file browser, it would be nicer not to show libtool object files (with extension .lo) and libtool libraries (.la).
Comment 1 Paolo Borelli 2013-06-16 08:41:35 UTC
Right now binary files are detected as binaries according to Gio's definition...


We need to decide how to tackle this... try to fix gio (or even the underlying shared-mime-info)? add our own white/black lists?
Comment 2 Garrett Regier 2013-06-16 08:43:37 UTC
Well technically .lo and .la files are text files, not binary. So the file browser's mime-type detection is correct. But maybe we can add a black list?
Comment 3 Adam Dingle 2013-06-16 09:23:14 UTC
.lo and .la files are really an odd edge case.  Technically they are text files, but semantically they are binary files and in my opinion it's bothersome to see them in the file browser when you're working in a tree where you've performed a build.

Since this is such an edge case, I'd lean toward having a simple blacklist that excludes (perhaps only) these file types when the user is filtering out binary files.  It's hard for me to think of another use case that would justify pushing this change into gio.
Comment 4 Garrett Regier 2013-06-16 11:22:26 UTC
I too cannot see how gio or shared-mime-info would allow a patch to make this binary as it would conflict too much.

Example: What if someone wanted to open the file? Well if the application first checks to see if the file is binary or text it would probably refuse to open it.


So, how should this be fixed?
    - Internal blacklist
    - Hidden setting
    - Setting exposed in the configure dialog

Any other solution ideas?
Comment 5 Ignacio Casal Quinteiro (nacho) 2013-06-16 11:33:37 UTC
I'd use a blacklist with a hidden setting, with the default values for those extensions...
Comment 6 Adam Dingle 2013-06-16 11:34:34 UTC
That sounds fine to me.  I think a visible setting for this would certainly be overkill.
Comment 7 Garrett Regier 2013-06-16 11:49:28 UTC
Created attachment 246938 [details] [review]
Bug 697428 - Add binary-patterns setting to the file browser

This is a list of extra glob patterns to consider as binary files.
Comment 8 Garrett Regier 2013-06-16 12:45:21 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.