After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697399 - GtkEntry: Add a "tabs" property for setting a PangoTabArray in the layout
GtkEntry: Add a "tabs" property for setting a PangoTabArray in the layout
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
3.8.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-04-05 22:56 UTC by David Trowbridge
Modified: 2013-08-19 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against gtk-3-8 (6.03 KB, patch)
2013-04-05 22:56 UTC, David Trowbridge 		reviewed Details | Review
Updated David's patch (6.01 KB, patch)
2013-08-15 18:38 UTC, A. Walton 		committed Details | Review

Description David Trowbridge 2013-04-05 22:56:20 UTC 
Created attachment 240807 [details] [review]
Patch against gtk-3-8

I'm currently working on porting view::FieldEntry (from libview) to C for use in upstream GTK+. FieldEntry is a widget which allows users to enter structured text such as IPv4 addresses or serial numbers. The way that FieldEntry delineates the fields within the entry is with tabstops, using PangoTabArray entries to precisely position the fields and delimiters. Because GtkEntry rebuilds its internal PangoLayout fairly frequently, this requires a property in the entry that will set the tabs on the layout whenever that happens. This API looks very similar to one in GtkTextView.
Comment 1 David Trowbridge 2013-05-13 20:40:08 UTC 
Ping?
Comment 2 Matthias Clasen 2013-08-10 14:22:00 UTC 
sorry, I'll put this on my review queue
Comment 3 Matthias Clasen 2013-08-11 21:56:35 UTC 
Review of attachment 240807 [details] [review]:

gtk.symbols doesn't exist anymore.
Instead, the patch should add the new functions to docs/reference/gtk3/gtk3-sections.txt.
All mentions of 3.8 should be updated to 3.10

::: gtk/gtkentry.c
@@ +2890,3 @@
 
+  if (priv->attrs)
+    pango_attr_list_unref (priv->attrs);

This looks like an independent memleak fix ? Should be committed separately.
Comment 4 A. Walton 2013-08-15 18:38:57 UTC 
Created attachment 251752 [details] [review]
Updated David's patch

Not sure how much David will be working on Gtk+ code these days, so I went ahead and updated the patch. git am gave me lots of grief trying to merge the patch, so I had to manually regenerate it (else I would have just signed off on it).
Comment 5 Matthias Clasen 2013-08-19 17:36:42 UTC 
Review of attachment 251752 [details] [review]:

Looks fine now