After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697346 - Add an entry to open the display properties from the background menu
Add an entry to open the display properties from the background menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.8.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-05 12:58 UTC by Julien Olivier
Modified: 2015-04-14 21:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed Patch (986 bytes, patch)
2015-03-25 16:42 UTC, Meet 		reviewed Details | Review
Add Display Settings to Background Menu. (951 bytes, patch)
2015-03-27 12:10 UTC, Meet 		none Details | Review
Add Display Settings to Background Menu. (1.19 KB, patch)
2015-03-31 08:21 UTC, Meet 		committed Details | Review

Description Julien Olivier 2013-04-05 12:58:54 UTC 
Now that gnome-shell has a background popup menu to access the background properties and the system settings, I think it would be logical to add an entry to open the display settings too. I know I used to right-click on the desktop to set the screen resolution at the time i was using Windows 95 or 98, and I used to find it quite logical...
Comment 1 Florian Müllner 2015-02-28 00:46:12 UTC 
Doesn't seem too far-fetched :-)

Designers, is this something we want?
Comment 2 Jakub Steiner 2015-03-16 15:59:44 UTC 
I don't see the menu growing, so I cautiously say I wouldn't mind. Allan?
Comment 3 Meet 2015-03-25 16:42:19 UTC 
Created attachment 300295 [details] [review]
Proposed Patch
Comment 4 Florian Müllner 2015-03-25 17:40:02 UTC 
Review of attachment 300295 [details] [review]:

A menu structure of
 * specific settings panel
 * settings overview
 * specific settings panel
is a bit odd. Would it make more sense to use something like:
 * Settings
--------------
 * Change Displays ...
 * Change Background ...
Comment 5 Florian Müllner 2015-03-25 17:40:57 UTC 
(In reply to Florian Müllner from comment #4)
>  * Change Displays ...

Or "Change Display Settings"
Comment 6 Meet 2015-03-27 12:10:39 UTC 
Created attachment 300436 [details] [review]
Add Display Settings to Background Menu.
Comment 7 Allan Day 2015-03-27 12:49:31 UTC 
I'm not entirely sure about the menu items in the patch:

Settings
---
Change Display Settings
Change Background...

There's no apparent logic for "display settings" being an action with a verb. Also, it's missing a "...".

None of these items are really actions - they are links. However, we do make an exception for the background item, because it doesn't work any other way ("Background" is ambiguous and "Background Settings" isn't quite logical).

So, I would suggest treating the display settings item as a link, since this is more accurate. I would also suggest ordering the items according to their relevance for the context (so that the more generic and less contextual "Settings" item is placed last):

Change Background...
---
Display Settings
Settings
Comment 8 Meet 2015-03-31 08:21:16 UTC 
Created attachment 300649 [details] [review]
Add Display Settings to Background Menu.
Comment 9 Meet 2015-03-31 08:24:41 UTC 
Sorry for delay (due to illness)
Comment 10 Florian Müllner 2015-03-31 20:25:00 UTC 
Review of attachment 300649 [details] [review]:

Looks good to me, thanks!
Comment 11 Florian Müllner 2015-04-14 21:20:20 UTC 
Attachment 300649 [details] pushed as 2105d2f - Add Display Settings to Background Menu.