GNOME Bugzilla – Bug 697146
gnome-disk-utility-3.8.0: update configure check for gsd-3.8
Last modified: 2015-03-27 03:46:07 UTC
Per: https://bugzilla.gnome.org/show_bug.cgi?id=690458 (found after getting https://bugs.gentoo.org/show_bug.cgi?id=463912 downstream) configure.ac needs to be updated to check for 3.8 g-s-d version. This is the wrong check: GSD_PLUGIN_REQUIRED=3.6 Thanks
Created attachment 240712 [details] [review] Bump required version of gnome-settings-daemon to 3.8 Reported by Pacho Ramos in https://bugzilla.gnome.org/697146 and from the references gentoo bug report: With gnome-base/gnome-settings-daemon-3.6.4: gdusdmanager.c: At top level: gdusdmanager.c:42:1: error: unknown type name 'GduSdClass' gdusdmanager.c:80:1: warning: 'gdu_sd_manager_start' defined but not used [-Wunused-function] gdusdmanager.c:124:1: warning: 'gdu_sd_manager_new' defined but not used [-Wunused-function] make[3]: *** [libgdu_sd_la-gdusdmanager.lo] Error 1
Created attachment 240713 [details] [review] Avoid needing gsd during build when --disable-gsd-plugin is used PKG_CHECK_MODULES was previously unconditionally requiring gnome-settings-daemon to be available, even when it was later not going to be used because the --disable-gsd-plugin configure switch was passed. Move the check to only require g-s-d when it's actually going to be used. While at it, also fix the indentation of the msg_gsd_plugin=yes line.
Thanks for these patches!