After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697046 - build server auto-updates
build server auto-updates
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
: 707762 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-01 14:11 UTC by Colin Walters
Modified: 2014-04-30 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rebuild itself (1.41 KB, patch)
2014-04-29 13:18 UTC, Vadim Rutkovsky 		reviewed Details | Review
Rebuild itself if --autoupdate-rebuild specified (2.30 KB, patch)
2014-04-30 08:31 UTC, Vadim Rutkovsky 		accepted-commit_now Details | Review

Description Colin Walters 2013-04-01 14:11:37 UTC 
The autobuilder.js code used to have an ugly hack to run "git pull -r" on itself, but:

* We aren't running make/make install, so we're not getting code updates
* We aren't updating dependencies like ostree, glib, gjs etc.

At the moment, the recommended build configuration is RHEL6 + jhbuild, but it's also possible to have packaged everything except gnome-ostree itself.

What we need is a way for gnome-ostree to gracefully update itself:

1) Run git pull -r
2) If changed, don't queue any more tasks, let the current ones finish
3) run build tool (jhbuild make)
4) restart

The default for 3) would be just jhbuild make, but for the RHEL6 configuration it'd need to be "jhbuild build gnome-ostree"
Comment 1 Colin Walters 2013-04-20 15:29:11 UTC 
Partially addressed by https://git.gnome.org/browse/gnome-ostree/commit/?id=fa13aadede36d715e184ae3964b249e80fedd276

We get manifest.json updates with this, but not code changes.
Comment 2 Colin Walters 2013-09-09 20:20:17 UTC 
*** Bug 707762 has been marked as a duplicate of this bug. ***
Comment 3 Vadim Rutkovsky 2014-04-29 13:18:44 UTC 
Created attachment 275421 [details] [review]
Rebuild itself

This makes gnome-continious do 'jhbuild make' (or jhbuild build gnome-continuous' if it fails) if autoupdate-self is specified. Not sure if this will make it re-run itself though
Comment 4 Colin Walters 2014-04-29 13:51:04 UTC 
Review of attachment 275421 [details] [review]:

Can you make this a separate command line option?  In the future I'm thinking about having Continuous deployed via Docker containers, and in that case we might still want to do the "git pull -r" to get new manifest versions, but have the actual code come from the container.
Comment 5 Vadim Rutkovsky 2014-04-30 08:31:17 UTC 
Created attachment 275470 [details] [review]
Rebuild itself if --autoupdate-rebuild specified

Added a different option --autoupdate-rebuild
Comment 6 Colin Walters 2014-04-30 12:13:08 UTC 
Review of attachment 275470 [details] [review]:

Looks good.  I'm not sure why the need to fall back to jhbuild build, but OK.  Thanks for the patch!