After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696792 - Compile HTML template pages as GResources
Compile HTML template pages as GResources
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-28 16:10 UTC by Carlos Garcia Campos
Modified: 2013-04-05 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (20.70 KB, patch)
2013-03-28 16:11 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2013-03-28 16:10:02 UTC
So that they are loaded from memory instead of disk every time they are needed. We also get rid of ephy_file searching for the files in the file system
Comment 1 Carlos Garcia Campos 2013-03-28 16:11:26 UTC
Created attachment 240067 [details] [review]
Patch
Comment 2 Xan Lopez 2013-04-01 09:07:27 UTC
Review of attachment 240067 [details] [review]:

OK, but make sure you are not breaking any test. Basically after this any test using those files needs to manually link with the resources object (there's already some examples).
Comment 3 Carlos Garcia Campos 2013-04-05 13:51:17 UTC
Comment on attachment 240067 [details] [review]
Patch

Yes, web view test failed because of this. Fixed and pushed to git master.