After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696763 - Don't crash on missing udev properties
Don't crash on missing udev properties
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
3.8.1
: 696994 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-28 10:32 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't crash on missing udev properties (1.19 KB, patch)
2013-03-28 10:32 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2013-03-28 10:32:03 UTC 
32001c4 added support for new udev properties added in recent udev
versions that are meant to replace the deprecated OSINFO_ properties.
However get_decoded_udev_property() is not dealing properly with
missing udev properties, and tries to call strlen() on a NULL string
when this happens, causing a crash.

This should fix rhbz#928495
Comment 1 Christophe Fergeau 2013-03-28 10:32:05 UTC 
Created attachment 240019 [details] [review]
Don't crash on missing udev properties
Comment 2 Zeeshan Ali 2013-03-28 14:11:22 UTC 
Review of attachment 240019 [details] [review]:

Thanks for the quick action! ACK
Comment 3 Zeeshan Ali 2013-03-31 20:56:50 UTC 
*** Bug 696994 has been marked as a duplicate of this bug. ***
Comment 4 Christophe Fergeau 2013-04-02 10:00:49 UTC 
Attachment 240019 [details] pushed as 34cbb6c - Don't crash on missing udev properties