After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696728 - Make about handlers asynchronous
Make about handlers asynchronous
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-27 18:52 UTC by Carlos Garcia Campos
Modified: 2013-06-14 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove the old about hanlder used in wk1 (6.08 KB, patch)
2013-03-27 18:53 UTC, Carlos Garcia Campos 		committed Details | Review
Refactor ephy about handler (19.89 KB, patch)
2013-03-27 18:54 UTC, Carlos Garcia Campos 		committed Details | Review
Make about:memory handler async (2.39 KB, patch)
2013-03-27 18:55 UTC, Carlos Garcia Campos 		committed Details | Review
Make about:applications async (2.46 KB, patch)
2013-03-27 18:55 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2013-03-27 18:52:33 UTC 
We were handling about:plugins differently because it's async in wk2. Now that wk1 code is gone we can refactor the about handler code to handle all about requests the same way and allow them to be asynchronous.
Comment 1 Carlos Garcia Campos 2013-03-27 18:53:27 UTC 
Created attachment 239979 [details] [review]
Remove the old about hanlder used in wk1
Comment 2 Carlos Garcia Campos 2013-03-27 18:54:47 UTC 
Created attachment 239980 [details] [review]
Refactor ephy about handler

This makes about handler a GObject owned by the ephy embed shell (thia ways the globals are now freed too) and unifies the way we handle about request using the same API.
Comment 3 Carlos Garcia Campos 2013-03-27 18:55:15 UTC 
Created attachment 239981 [details] [review]
Make about:memory handler async
Comment 4 Carlos Garcia Campos 2013-03-27 18:55:42 UTC 
Created attachment 239982 [details] [review]
Make about:applications async
Comment 5 Xan Lopez 2013-05-31 08:51:54 UTC 
Review of attachment 239979 [details] [review]:

OK.
Comment 6 Xan Lopez 2013-05-31 08:55:26 UTC 
Review of attachment 239980 [details] [review]:

This is great!
Comment 7 Xan Lopez 2013-05-31 08:56:25 UTC 
Review of attachment 239981 [details] [review]:

OK.
Comment 8 Xan Lopez 2013-05-31 08:56:48 UTC 
Review of attachment 239982 [details] [review]:

OK.
Comment 9 Carlos Garcia Campos 2013-06-05 06:56:27 UTC 
Comment on attachment 239982 [details] [review]
Make about:applications async

I've just noticed I pushed this one by mistake too. It's pretty simple, so I don't think it's worth reverting it. Please take a look a look to confirm it's sane.