After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696606 - qtdemux memory leak
qtdemux memory leak
Status: RESOLVED DUPLICATE of bug 696355
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.5
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-26 02:38 UTC by zhangyanping
Modified: 2013-03-26 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description zhangyanping 2013-03-26 02:38:52 UTC
At qtdemux.c 

static void
qtdemux_tag_add_blob (GNode * node, GstQTDemux * demux)

line 8680

//-------------------------------
  sample = gst_sample_new (buf, NULL, NULL, s);
  gst_buffer_unref (buf);
  g_free (media_type);

  GST_DEBUG_OBJECT (demux, "adding private tag; size %d, info %" GST_PTR_FORMAT,
      len, s);

  gst_tag_list_add (demux->tag_list, GST_TAG_MERGE_APPEND,
      GST_QT_DEMUX_PRIVATE_TAG, sample, NULL);

//------------------------------------------

I think the sample should be unref after added to the tag list.
Comment 1 Tim-Philipp Müller 2013-03-26 10:27:50 UTC
Thanks for the bug report.

I believe this is fixed already in the 1.0.6 release:

 commit 522f006a3c951009b4aa0330c3b11dc8203763d3
 Author: Rodolfo Schulz de Lima <rodolfo@rodsoft.org>
 Date:   Fri Mar 22 08:47:17 2013 +0000

     qtdemux: fix sample leak when processing private qt tags
    
     https://bugzilla.gnome.org/show_bug.cgi?id=696355

*** This bug has been marked as a duplicate of bug 696355 ***