After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696541 - tests: test_play_multithreaded doesn't stop listening
tests: test_play_multithreaded doesn't stop listening
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-25 09:51 UTC by David Svensson Fors
Modified: 2014-02-25 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GSocketService cleanup (863 bytes, patch)
2013-03-25 09:51 UTC, David Svensson Fors 		committed Details | Review

Description David Svensson Fors 2013-03-25 09:51:21 UTC 
Created attachment 239736 [details] [review]
GSocketService cleanup

In gst-rtsp-server, run rtspserver check tests with CK_FORK=no and fatal warnings:

CK_FORK=no G_DEBUG=fatal-warnings make -C tests/check gst/rtspserver.check

The test fails with "GLib-GIO-WARNING **: fail: Socket is already closed"

In a gdb backtrace, it can be seen that the warning comes when g_socket_service_ready is called during test_play_multithreaded. The problem is that no GSocketService is used in that test. It remains from the previous test test_bind_already_in_use, which hasn't cleaned up properly.

The attached patch is a suggested fix for the problem. g_socket_service_stop is used in test_bind_already_in_use, so the socket service stops listening for incoming connections.
Comment 1 Tim-Philipp Müller 2013-03-28 12:49:39 UTC 
Thanks, pushed:


commit 75221ac8e3780fb2e8f9e23bfb616389d505515e
Author: David Svensson Fors <davidsf@axis.com>
Date:   Wed Mar 20 11:28:11 2013 +0100

    tests: GSocketService cleanup in test_bind_already_in_use
    
    Use g_socket_service_stop so the rtspserver test stops listening for
    incoming connections in test_bind_already_in_use.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=696541