After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696412 - Breaks ABI without bumping SONAME
Breaks ABI without bumping SONAME
Status: RESOLVED INVALID
Product: gtksourceview
Classification: Platform
Component: General
3.7.x
Other Linux
: Normal trivial
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-22 17:57 UTC by Andreas Henriksson
Modified: 2013-03-23 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Andreas Henriksson 2013-03-22 17:57:24 UTC 
When preparing updated packages for Debian I noticed that many public symbols had been removed. This breaks ABI and the SONAME should be bumped when doing so. I investigated further and found out that there are many users of some of the removed API. :(

For a list of the dropped API (which either needs to be restored or SONAME bumped), see:

http://anonscm.debian.org/viewvc/pkg-gnome/desktop/experimental/gtksourceview3/debian/libgtksourceview-3.0-0.symbols?r1=37132&r2=37133
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-03-22 18:48:09 UTC 
Ok, that's weird. Those are internal methods that were not exposed... In this release we extra marked them with G_GNUC_INTERNAL.
Comment 2 Sébastien Wilmet 2013-03-22 19:49:29 UTC 
These private functions were exposed in the ABI, because they were not prefixed by an underscore. So it was possible to use these symbols by copying the private headers, but it's a really bad practice.

I think a soname bump is enough. For this, the patch in bug #477709 could be useful.

(In reply to comment #0)
> I investigated further and found out that there are many users of some of
> the removed API. :(

Surprising! Can you easily list those symbols and the applications using them?
Comment 3 Andreas Henriksson 2013-03-22 22:35:47 UTC 
(In reply to comment #2)
> (In reply to comment #0)
> > I investigated further and found out that there are many users of some of
> > the removed API. :(
> 
> Surprising! Can you easily list those symbols and the applications using them?

Only the users within debian.... http://codesearch.debian.net
Comment 4 Andreas Henriksson 2013-03-22 22:46:14 UTC 
I see not all symbols starting with a particula prefix was removed, maybe I cast my search too wide..... will look closer.
Comment 5 Andreas Henriksson 2013-03-22 23:10:22 UTC 
Looked over all symbols individually (boring as hell) and ignored matches inside gtksourceview2 and gtksourceview3 in the results.... Have to say I'm sorry. Doesn't seem like the symbols are used (inside Debian). Still, removed symbols should result in a new so version.... Sorry  for severely inflating the severity of this bug. Will close it as INVALID. Would be happy if you could still consider bumping so version when removing public symbols in the future.... Removed symbols always makes me nervous.
Comment 6 Sébastien Wilmet 2013-03-23 12:40:21 UTC 
soname version bumped.

Thanks for the search and the bug report.