GNOME Bugzilla – Bug 696409
ATK tests fail because of incorrect hyphenation
Last modified: 2013-03-27 18:25:40 UTC
Created attachment 239565 [details] [review] Remove incorrect hyphenation from ATK 'testrelation' tests. The module 'atk/tests/testrelation.c' compiles and builds correctly but it fails at run time. Failure is due to the fact that some strings are retrieved from an array called "roles" (defined in atk/atkobject.c). Immediately after retrieval, the strings are compared to see if they match an expected string, such as "page-tab", "layered-pane" and "list-item". It looks like the array strings must have gotten changed at some point because (in the array) they're no longer hyphenated. The attached patch fixes testrelation.c to use the equivalent, un-hyphenated string in each case, namely:- "page tab", "layered pane" and "list item".
(In reply to comment #0) > Created an attachment (id=239565) [details] > Remove incorrect hyphenation from ATK 'testrelation' tests. Looks good. I will commit it as soon as the hard code freeze [1] ends. One question: do you have access to commit the patch or do you need me to commit it on your behalf? [1] https://live.gnome.org/ThreePointSeven
You should do it please, Alejandro. I don't have write access upstream. Thanks. John
(In reply to comment #2) > You should do it please, Alejandro. I don't have write access upstream. Thanks. > > John Patch committed. Closing the bug. Thanks.
Is this patch commited upstream yet? A git pull still gives me the previous (hyphenated) text. I'm pulling from 'master' AFAIK.
(In reply to comment #4) > Is this patch commited upstream yet? A git pull still gives me the previous > (hyphenated) text. I'm pulling from 'master' AFAIK. Yeah sorry, I only pushed this to the branch gnome-3-8. I have just pushed it also to master. Thanks for pointing it.
Thanks Alejandro - that seems to have done the trick!