After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696239 - libvirt-machine-props: Fix reboot code
libvirt-machine-props: Fix reboot code
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 696242
 
 
Reported: 2013-03-20 23:12 UTC by Zeeshan Ali
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libvirt-machine-props: Fix reboot code (1.60 KB, patch)
2013-03-20 23:12 UTC, Zeeshan Ali 		reviewed Details | Review
libvirt-machine-props: Fix reboot code (2.07 KB, patch)
2013-03-21 12:49 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2013-03-20 23:12:08 UTC 
See patch
Comment 1 Zeeshan Ali 2013-03-20 23:12:11 UTC 
Created attachment 239424 [details] [review]
libvirt-machine-props: Fix reboot code

Due to a regression from commit e176e57, we were listening to 'state'
property change notification on wrong object and as result we were not
starting the box after its shutdown.
Comment 2 Christophe Fergeau 2013-03-21 09:27:27 UTC 
Review of attachment 239424 [details] [review]:

::: src/libvirt-machine-properties.vala
@@ +465,3 @@
                 if (machine.state == Machine.MachineState.STOPPED ||
                     machine.state == Machine.MachineState.FORCE_STOPPED) {
                     debug ("'%s' stopped.", machine.name);

There's a
this.disconnect (state_id);
further below, shouldn't it be machine.disconnect(state_id)? (didn't have my morning coffee yet, so I may not make sense yet ;)
Comment 3 Zeeshan Ali 2013-03-21 12:49:23 UTC 
Created attachment 239463 [details] [review]
libvirt-machine-props: Fix reboot code

Due to a regression from commit e176e57, we were listening to 'state'
property change notification on wrong object and as result we were not
starting the box after its shutdown.
Comment 4 Zeeshan Ali 2013-03-26 00:43:12 UTC 
Attachment 239463 [details] pushed as 89ede18 - libvirt-machine-props: Fix reboot code