After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696232 - win32: do not crash on invalid utf8 conversion
win32: do not crash on invalid utf8 conversion
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-20 22:14 UTC by Marc-Andre Lureau
Modified: 2013-03-23 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
win32: do not crash on invalid utf8 conversion (1.37 KB, patch)
2013-03-20 22:14 UTC, Marc-Andre Lureau
committed Details | Review

Description Marc-Andre Lureau 2013-03-20 22:14:05 UTC
g_utf8_to_utf16() is not guaranteed to succeed. Check the error
and return if it failed.
Comment 1 Marc-Andre Lureau 2013-03-20 22:14:08 UTC
Created attachment 239414 [details] [review]
win32: do not crash on invalid utf8 conversion
Comment 2 Matthias Clasen 2013-03-23 17:40:14 UTC
Review of attachment 239414 [details] [review]:

Looks fine to me
Comment 3 Matthias Clasen 2013-03-23 19:49:39 UTC
Attachment 239414 [details] pushed as 564b4e6 - win32: do not crash on invalid utf8 conversion