After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696212 - lock screen exception in initial-setup mode
lock screen exception in initial-setup mode
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-20 17:29 UTC by Colin Walters
Modified: 2013-03-24 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
journal output (7.07 KB, text/plain)
2013-03-20 17:29 UTC, Colin Walters 		  Details
initial-setup: Add battery icon (1001 bytes, patch)
2013-03-23 09:31 UTC, drago01 		committed Details | Review

Description Colin Walters 2013-03-20 17:29:56 UTC 
Created attachment 239391 [details]
journal output

Got the following with the current gnome-ostree master:
Comment 1 Giovanni Campagna 2013-03-20 17:34:25 UTC 
Looks like that the initial-setup session is trying to instantiate the lockScreen button (combinated volume-battery-network), and choking because there is no battery indicator.

Given that we have battery in gdm, it looks correct to me to have battery in initial-setup too, but maybe there is a reason for this difference.
Comment 2 Cosimo Cecchi 2013-03-20 19:20:33 UTC 
I can't think of any reason why initial-setup should be special wrt. the battery indicator, but indeed I don't see it in the designs...
Comment 3 drago01 2013-03-23 09:28:19 UTC 
(In reply to comment #2)
> I can't think of any reason why initial-setup should be special wrt. the
> battery indicator, but indeed I don't see it in the designs...

I don't care about "what is in the design" there is NO reason not to show the battery there.
Comment 4 drago01 2013-03-23 09:31:00 UTC 
Created attachment 239620 [details] [review]
initial-setup: Add battery icon

There is no reason why there shouldn't be a battery icon in initial-setup,
knowing how much battery you have left is useful in during setup as well.

This also fixes an exception in the lock screen caused by the combined icon
not finding the battery one.
Comment 5 Giovanni Campagna 2013-03-23 12:55:52 UTC 
Review of attachment 239620 [details] [review]:

This is probably right.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-03-23 16:41:40 UTC 
We should probably ship the initial-setup mode in gnome-initial-setup now that we have external session modes.
Comment 7 Matthias Clasen 2013-03-24 03:42:51 UTC 
but for 3.8.0, lets just take the minimal fix here.
Comment 8 Matthias Clasen 2013-03-24 04:05:15 UTC 
I'll give my +1 for the release team here. Please ask for a second approval
Comment 9 André Klapper 2013-03-24 08:14:05 UTC 
Second +1 for release team. Go ahead.
Comment 10 drago01 2013-03-24 08:39:54 UTC 
Attachment 239620 [details] pushed as 9b3b419 - initial-setup: Add battery icon